fix: check if external symbol before checking from same scope. #2434
Conversation
|
I thought the ExternalSymbol should still be part of the current symbol table. I will need to investigate this. Also let's add a test that now works. |
arteevraina
force-pushed
the
fix-2428
branch
from
5b3b78c
to
56b964d
Compare
| // If the symbol is an ExternalSymbol, then omit the check. | ||
| if (ASR::is_a<ASR::ExternalSymbol_t>(*symbol)) { | ||
| return; | ||
| } |
There was a problem hiding this comment.
I think this change is not correct --- I think the ASR is incorrect if the ExternalSymbol is not present in the current scope. So there is a bug in the way we construct the ASR that we need to fix.
There was a problem hiding this comment.
The symbol is there in the current_symtab imported as ExternalSymbol. But, x.m_derived_type points to actual definition of the class which is inside another module, that is why symtab_in_scope fails. I think ASR is correct as the External Symbol is there in the current scope.
There was a problem hiding this comment.
The proper fix is described at lfortran/lfortran#2957.
ExternalSymbol, it should omit the same scope check in ASR Verify.