Improve global bootstrap optimizer configuration #2080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently global bootstrap uses "accuracy" in several different ways: * For all parameters passed to LevenbergMarquardt. * For all epsilon parameters passed to EndCriteria. * As the upper bound on the final value of the cost function. This overloading makes it quite inflexible. Instead: * Allow passing optimizer and EndCriteria to the constructor, which allows full control over all parameters. * Instead of checking the final value of the cost function, check the result type from the optimizer. Also, cleanup LevenbergMarquardt optimizer: remove commented out code, fix parameters passed to MINPACK.
|
CC @pcaspers in case you are interested. I believe you wrote some of this code. |
|
@lballabio the codacy error is a very obvious false positive. Is there a way to suppress it? |
Yes, I'll silence it next week when I'm back from a few days off |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently global bootstrap uses "accuracy" in several different ways:
This overloading makes it quite inflexible. Instead:
Also, cleanup LevenbergMarquardt optimizer: remove commented out code, fix parameters passed to MINPACK.