Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Break ring of shared_ptr<Stock> dependencies #1727

Merged
merged 2 commits into from
Jul 12, 2023
Merged

Break ring of shared_ptr<Stock> dependencies #1727

merged 2 commits into from
Jul 12, 2023

Conversation

ralfkonrad
Copy link
Contributor

Solves #1725.

@ralfkonrad ralfkonrad changed the title Break ring of shared_ptr<Stock> Break ring of shared_ptr<Stock> dependencies Jul 11, 2023
@coveralls
Copy link

coveralls commented Jul 11, 2023 •
edited
Loading

Coverage Status

coverage: 71.885% (+0.001%) from 71.884% when pulling 7362bcc on ralfkonrad:break_QL_THROW_IN_CYCLES_ring into 343ee92 on lballabio:master.

@ralfkonrad ralfkonrad mentioned this pull request Jul 11, 2023
Closed
@lballabio lballabio added this to the Release 1.31 milestone Jul 12, 2023
@lballabio
Copy link
Owner

Thanks!

@lballabio lballabio linked an issue Jul 12, 2023 that may be closed by this pull request
LazyObjectTest::testNotificationLoop causes errors later on when combined with QL_THROW_IN_CYCLES and Instrument registers with Settings::evaluationDate() #1725
Closed
@lballabio lballabio merged commit e964a67 into lballabio:master Jul 12, 2023
45 checks passed
pcaspers
pcaspers reviewed Jul 12, 2023
View reviewed changes
test-suite/lazyobject.cpp
@@ -193,6 +193,11 @@ void LazyObjectTest::testNotificationLoop() {

#endif

// We have produced a ring of dependencies which we break here
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we use RAII to guarantee that the unregistering happens?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe? If we don't get here, though, it means that the test suite already failed. Ok for now, I guess, but feel free to open a PR.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general 👍

But, now that the PR is merged, is it worth the effort?!

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It could be someone's way to spend some time if they get bored and run out of series to watch :)

@ralfkonrad ralfkonrad deleted the break_QL_THROW_IN_CYCLES_ring branch July 12, 2023 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lballabio lballabio lballabio left review comments

@pcaspers pcaspers pcaspers left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release 1.31
4 participants
@ralfkonrad @coveralls @lballabio @pcaspers