Re-enable deprecation warnings for recent Clang versions

lballabio · Oct 2, 2024 · 460a948 · 460a948
1 parent 57df9d4
commit 460a948
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 17 deletions.
diff --git a/.github/workflows/linux-full-tests.yml b/.github/workflows/linux-full-tests.yml
@@ -105,13 +105,11 @@ jobs:
             tag: noble
             cc: clang
             cxx: clang++
-            cxxflags: -Wno-deprecated-declarations
           - name: "Clang 19"
             shortname: clang19
             tag: oracular
             cc: clang
             cxx: clang++
-            cxxflags: -Wno-deprecated-declarations
           - name: "C++17 mode"
             shortname: c++17
             tag: rolling

diff --git a/.github/workflows/linux-nondefault.yml b/.github/workflows/linux-nondefault.yml
@@ -100,13 +100,11 @@ jobs:
             tag: noble
             cc: clang
             cxx: clang++
-            cxxflags: -Wno-deprecated-declarations
           - name: "Clang 19"
             shortname: clang19
             tag: oracular
             cc: clang
             cxx: clang++
-            cxxflags: -Wno-deprecated-declarations
           - name: "C++17 mode"
             shortname: c++17
             tag: rolling

diff --git a/.github/workflows/linux.yml b/.github/workflows/linux.yml
@@ -44,14 +44,12 @@ jobs:
             tag: noble
             cc: clang
             cxx: clang++
-            cxxflags: -Wno-deprecated-declarations
             tests: true
           - name: "Clang 19"
             shortname: clang19
             tag: oracular
             cc: clang
             cxx: clang++
-            cxxflags: -Wno-deprecated-declarations
             tests: true
           - name: "C++17 mode"
             shortname: c++17

diff --git a/ql/currency.cpp b/ql/currency.cpp
@@ -89,16 +89,10 @@ namespace QuantLib {
                        const std::string& formatString,
                        const Currency& triangulationCurrency,
                        const std::set<std::string>& minorUnitCodes)
-    : data_(ext::make_shared<Currency::Data>(name,
-                                             code,
-                                             numericCode,
-                                             symbol,
-                                             fractionSymbol,
-                                             fractionsPerUnit,
-                                             rounding,
-                                             formatString,
-                                             triangulationCurrency,
-                                             minorUnitCodes)) {}
+    : Currency(name, code, numericCode, symbol, fractionSymbol, fractionsPerUnit,
+               rounding, triangulationCurrency, minorUnitCodes) {
+        data_->formatString = formatString;
+    }
 
     QL_DEPRECATED_ENABLE_WARNING
 

diff --git a/ql/currency.hpp b/ql/currency.hpp
@@ -139,7 +139,7 @@ namespace QuantLib {
         /*! \deprecated Use the constructor without formatString.
                         Deprecated in version 1.33.
         */
-        QL_DEPRECATED
+        [[deprecated("Use the constructor without formatString")]]
         Data(std::string name,
              std::string code,
              Integer numericCode,