Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for 2024b and update default to 2024a #144

Closed
wants to merge 1 commit into from

Conversation

ruslandoga
Copy link

@ruslandoga ruslandoga commented Sep 6, 2024

temp fix for #143


update default to 2024a

Somehow https://data.iana.org/time-zones/tzdata-latest.tar.gz returns 2024a for me. Also #144 (comment)

@@ -10,6 +10,6 @@
"mimerl": {:hex, :mimerl, "1.2.0", "67e2d3f571088d5cfd3e550c383094b47159f3eee8ffa08e64106cdf5e981be3", [:rebar3], [], "hexpm", "f278585650aa581986264638ebf698f8bb19df297f66ad91b18910dfc6e19323"},
"nimble_parsec": {:hex, :nimble_parsec, "1.1.0", "3a6fca1550363552e54c216debb6a9e95bd8d32348938e13de5eda962c0d7f89", [:mix], [], "hexpm", "08eb32d66b706e913ff748f11694b17981c0b04a33ef470e33e11b3d3ac8f54b"},
"parse_trans": {:hex, :parse_trans, "3.3.0", "09765507a3c7590a784615cfd421d101aec25098d50b89d7aa1d66646bc571c1", [:rebar3], [], "hexpm", "17ef63abde837ad30680ea7f857dd9e7ced9476cdd7b0394432af4bfc241b960"},
"ssl_verify_fun": {:hex, :ssl_verify_fun, "1.1.6", "cf344f5692c82d2cd7554f5ec8fd961548d4fd09e7d22f5b62482e5aeaebd4b0", [:make, :mix, :rebar3], [], "hexpm", "bdb0d2471f453c88ff3908e7686f86f9be327d065cc1ec16fa4540197ea04680"},
"ssl_verify_fun": {:hex, :ssl_verify_fun, "1.1.7", "354c321cf377240c7b8716899e182ce4890c5938111a1296add3ec74cf1715df", [:make, :mix, :rebar3], [], "hexpm", "fe4c190e8f37401d30167c8c405eda19469f34577987c76dde613e838bbc67f8"},
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ruslandoga ruslandoga mentioned this pull request Sep 6, 2024
4 tasks
@ruslandoga
Copy link
Author

ruslandoga commented Sep 6, 2024

Seems like there are more problems with 2024b. With it, tzdata fails to identify zone_abbr in some datetimes:

on 2024b: #DateTime<2015-01-13 07:00:07-12:00 %z Etc/GMT+12>
on 2024a: #DateTime<2015-01-13 07:00:07-12:00 -12 Etc/GMT+12>

From https://github.com/plausible/analytics/actions/runs/10734360261/job/29769389260

@lau
Copy link
Owner

lau commented Sep 11, 2024

Seems like there are more problems with 2024b. With it, tzdata fails to identify zone_abbr in some datetimes:

Thanks for mentioning that. This should be fixed in the recently released tzdata version 1.1.2.

@lau lau closed this Sep 11, 2024
@ruslandoga ruslandoga deleted the fix-for-2024b branch September 11, 2024 06:13
@ruslandoga ruslandoga restored the fix-for-2024b branch September 11, 2024 06:13
@ruslandoga
Copy link
Author

@lau thank you for the fixes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants