Skip to content

Commit

Permalink
updating to do list
Browse files Browse the repository at this point in the history
  • Loading branch information
landoskape committed May 10, 2024
1 parent 7db00e3 commit 3ce0e24
Showing 1 changed file with 2 additions and 5 deletions.
7 changes: 2 additions & 5 deletions dominoes.ipynb
Original file line number Diff line number Diff line change
Expand Up @@ -107,18 +107,15 @@
},
{
"cell_type": "code",
"execution_count": 3,
"execution_count": 5,
"id": "40c715a5",
"metadata": {},
"outputs": [],
"source": [
"# TODO For refactoring\n",
"# at the moment there is no flexibility on the loss function control for the supervised dataset!!!!\n",
"\n",
"# Handling arguments for pointer construction in experiment module\n",
"# -- need to add arglibs for all components of pointer networks\n",
"# -- need to build pointer kwargs intelligently (in pointer_networks.py) \n",
"# --- just put decoder / encoder / pointer kwargs all in get_pointer_kwargs method and return as distinct dicts"
"# Add mechanism for printing the arguments used to build a pointernetwork so the user can see what they did. "
]
},
{
Expand Down

0 comments on commit 3ce0e24

Please sign in to comment.