feat!: combine LanceFragment.merge_columns and LanceDataset.add_columns in one implementation #3021
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These two methods were very similar but took different arguments. This combines the implementation of the two methods.
In addition:
Updater
was removed as:merge_columns
now usesFragment::add_columns
)LanceFragment.add_columns
was removed since it has been deprecated for six months and could be confusing.In a few weeks it might be good to deprecate
LanceFragment.merge_columns
and addLanceFragment.add_columns
back with a new signature that mirrorsLanceDataset.add_columns
.BREAKING CHANGE: The rust method
LanceDataset.add_columns
now has an optionalbatch_size
parameter.