feat: add 2.1 read path #2968
Open
feat: add 2.1 read path #2968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
westonpace
changed the title
westonpace
force-pushed
the
feat/repdef
branch
from
6835261
to
d216677
Compare
westonpace
force-pushed
the
feat/repdef
branch
4 times, most recently
from
200acf0
to
65b00c1
Compare
westonpace
changed the title
westonpace
force-pushed
the
feat/repdef
branch
from
5c685c0
to
ac98d0b
Compare
westonpace
requested review from
broccoliSpicy and
wjones127
and removed request for
broccoliSpicy
broccoliSpicy
approved these changes
Oct 22, 2024
wjones127
approved these changes
Oct 22, 2024
Comment on lines
+533
to
+534
| // TODO: Not that trivial, we might have rep/def that we need to encode / decode still | ||
| todo!() |
There was a problem hiding this comment.
Should these be filled in for this PR? Or are we just not writing them yet so it doesn't matter?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unlike the write path we were not able to get away with subtle changes to the existing traits. Most of the read traits needed to be duplicated. On the bright side, there is very little impact to the existing reader code though :)