Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Will Jones <[email protected]>
  • Loading branch information
westonpace and wjones127 authored Oct 15, 2024
1 parent da85768 commit 12c2d9b
Showing 1 changed file with 3 additions and 25 deletions.
28 changes: 3 additions & 25 deletions rust/lance/src/io/exec/take.rs
Original file line number Diff line number Diff line change
Expand Up @@ -396,14 +396,8 @@ mod tests {

// With row id
let config = LanceScanConfig {
batch_size: 10,
batch_readahead: 10,
fragment_readahead: Some(4),
io_buffer_size: *DEFAULT_IO_BUFFER_SIZE,
with_row_id: true,
with_row_address: false,
with_make_deletions_null: false,
ordered_output: true,
..Default::default()
};
let input = Arc::new(LanceScanExec::new(
dataset.clone(),
Expand Down Expand Up @@ -435,14 +429,8 @@ mod tests {
let extra_schema = Arc::new(Schema::try_from(&extra_arrow_schema).unwrap());

let config = LanceScanConfig {
batch_size: 10,
batch_readahead: 10,
fragment_readahead: Some(4),
io_buffer_size: *DEFAULT_IO_BUFFER_SIZE,
with_row_id: true,
with_row_address: false,
with_make_deletions_null: false,
ordered_output: true,
..Default::default(),

Check failure on line 433 in rust/lance/src/io/exec/take.rs

View workflow job for this annotation

GitHub Actions / linux-arm

cannot use a comma after the base struct

Check failure on line 433 in rust/lance/src/io/exec/take.rs

View workflow job for this annotation

GitHub Actions / linux-build (stable)

cannot use a comma after the base struct

Check failure on line 433 in rust/lance/src/io/exec/take.rs

View workflow job for this annotation

GitHub Actions / linux-build (nightly)

cannot use a comma after the base struct
};
let input = Arc::new(LanceScanExec::new(
dataset.clone(),
Expand Down Expand Up @@ -473,22 +461,12 @@ mod tests {
let extra_schema = Arc::new(Schema::try_from(&extra_arrow_schema).unwrap());

// No row ID
let config = LanceScanConfig {
batch_size: 10,
batch_readahead: 10,
fragment_readahead: Some(4),
io_buffer_size: *DEFAULT_IO_BUFFER_SIZE,
with_row_id: false,
with_row_address: false,
with_make_deletions_null: false,
ordered_output: true,
};
let input = Arc::new(LanceScanExec::new(
dataset.clone(),
dataset.fragments().clone(),
None,
scan_schema,
config,
..Default::default(),
));
assert!(TakeExec::try_new(dataset, input, extra_schema, 10).is_err());
}
Expand Down

0 comments on commit 12c2d9b

Please sign in to comment.