Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve wallet and provider integration testing #90

Merged
merged 5 commits into from
Aug 28, 2023
Merged

Conversation

IAvecilla
Copy link
Contributor

No description provided.

Copy link
Collaborator

@ilitteri ilitteri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! You could use this PR or we could use another one but it'd be nice to have a test_helpers module.

@IAvecilla
Copy link
Contributor Author

IAvecilla commented Jul 21, 2023

Very nice! You could use this PR or we could use another one but it'd be nice to have a test_helpers module.

I used this same PR to make this change, and I modified some places where we were not using the test utils. I also renamed the file to just utils since it is inside the test directory. Feel free to comment on these changes 🙂

@codecov-commenter
Copy link

Codecov Report

Merging #90 (e8b95b0) into main (39f010b) will decrease coverage by 9.45%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main      #90      +/-   ##
==========================================
- Coverage   83.02%   73.58%   -9.45%     
==========================================
  Files          13       12       -1     
  Lines        3170     1923    -1247     
==========================================
- Hits         2632     1415    -1217     
+ Misses        538      508      -30     
Impacted Files Coverage Δ
src/zks_provider/mod.rs 81.47% <ø> (-9.61%) ⬇️
src/zks_wallet/wallet.rs 75.00% <ø> (-10.27%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@IAvecilla IAvecilla self-assigned this Jul 21, 2023
@mationorato mationorato changed the title Move wallet and provider tests to separate test module Improve wallet and provider integration testing Jul 24, 2023
@jpcenteno jpcenteno self-requested a review August 28, 2023 16:14
Copy link
Contributor

@jpcenteno jpcenteno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@IAvecilla IAvecilla merged commit 2a770b2 into main Aug 28, 2023
4 checks passed
@IAvecilla IAvecilla deleted the move_tests branch August 28, 2023 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants