-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve wallet and provider integration testing #90
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice! You could use this PR or we could use another one but it'd be nice to have a test_helpers module.
I used this same PR to make this change, and I modified some places where we were not using the test utils. I also renamed the file to just |
Codecov Report
@@ Coverage Diff @@
## main #90 +/- ##
==========================================
- Coverage 83.02% 73.58% -9.45%
==========================================
Files 13 12 -1
Lines 3170 1923 -1247
==========================================
- Hits 2632 1415 -1217
+ Misses 538 508 -30
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.