Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README code examples #112

Merged
merged 7 commits into from
Oct 3, 2023
Merged

Update README code examples #112

merged 7 commits into from
Oct 3, 2023

Conversation

fkrause98
Copy link
Contributor

@fkrause98 fkrause98 commented Sep 11, 2023 •
edited
Loading

Changes:

  • Update readme examples that did not work when followed.
  • Add CI step to check examples compile.

@codecov-commenter
Copy link

Codecov Report

Merging #112 (0774af4) into main (fd7adf6) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #112   +/-   ##
=======================================
  Coverage   68.15%   68.15%           
=======================================
  Files          18       18           
  Lines        2179     2179           
=======================================
  Hits         1485     1485           
  Misses        694      694

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@fkrause98 fkrause98 mentioned this pull request Sep 14, 2023
Open
mationorato
mationorato approved these changes Oct 3, 2023
View reviewed changes
Copy link
Collaborator

@mationorato mationorato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mationorato mationorato merged commit 9e83f8b into main Oct 3, 2023
5 checks passed
@mationorato mationorato deleted the update-readme branch October 3, 2023 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mationorato mationorato mationorato approved these changes

@jpcenteno jpcenteno Awaiting requested review from jpcenteno

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fkrause98 @codecov-commenter @mationorato