Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement GetDungeonAfkRewards message #694

Closed
wants to merge 1 commit into from

Conversation

ncontinanza
Copy link
Contributor

@ncontinanza ncontinanza commented Jun 10, 2024

Motivation

We need to get the Dungeon AFK rewards and send them to the client.

Summary of changes

Implement the GetDungeonAfkRewards message and the logic for its response.

How to test it?

Follow the steps to claim the Dungeon AFK Rewards here: lambdaclass/afk_gacha_game#487

Checklist

  • Tested the changes locally.
  • Reviewed the changes on GitHub, line by line.
  • This change requires new documentation.
    • Documentation has been added/updated.

@ncontinanza ncontinanza marked this pull request as ready for review June 10, 2024 22:21
Copy link
Contributor

@lotuuu lotuuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add some simple testing of the GetDungeonAfkRewards message with the SocketTester! even if really basic these tests are the most important ones since they can easily be broken by missing preloads or schema modifications

@ncontinanza
Copy link
Contributor Author

We won't be using this message as the Dungeon AFK rewards will be claimed automatically.
In the future, this issue will have to be addressed for that behaviour to work properly: lambdaclass/afk_gacha_game#491

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants