'Self' targeting strategy #585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lotuuu
requested changes
May 9, 2024
lotuuu
requested changes
May 9, 2024
There was a problem hiding this comment.
Tests are still not doing what they are supposed to do! You can check what's going on for the battle in a test by changing the logger config in file tests.exs to:
config :logger, level: :info
This will let you see info logs in tests.
You can run specific tests like:
mix test apps/champions/test/battle_test.exs:749
Also, you marked some comments from my last review as resolved but didn't commit the suggestion/address the comment, be careful there!
lotuuu
approved these changes
May 13, 2024
4 tasks
ncontinanza
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes [TargetingStrategy] Self
Motivation
Implement new strategy to target the caster unit of a skill.
Summary of changes
New choose_targets function clause with the 'self' type of targeting strategy, it returns the caster unit id.
How to test it?
Set the targeting strategy for one of your unit character's skills to "self", you can do so in the skills.json file, running Champions.Config.import_skill_config() to update the running backend. Then run a battle and verify when the modified skill is cast, it targeted the same unit that casted it. You can check battle.md on how to run battles.
Checklist