Removed RELEASE workflow input on GitHub Actions. #449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samoht9277
commented
Apr 8, 2024
There was a problem hiding this comment.
By removing this, we no longer have a way of confirming if the release we are deploying is the same as the already deployed (if any).
Since we no longer have the option to choose which release we want, these lines are no longer in need.
However, the loadtest client servers still have the choice to select between loadtest and bots manager. In this case, the script would generate two different services that run concurrently.
Nico-Sanchez
previously approved these changes
Apr 8, 2024
Nico-Sanchez
temporarily deployed
to
testing-europe
GitHub Actions
Inactive
samoht9277
had a problem deploying
to
testing-brazil
GitHub Actions
Failure
samoht9277
had a problem deploying
to
testing-brazil
GitHub Actions
Failure
samoht9277
had a problem deploying
to
testing-brazil
GitHub Actions
Failure
samoht9277
had a problem deploying
to
testing-brazil
GitHub Actions
Failure
samoht9277
had a problem deploying
to
testing-brazil
GitHub Actions
Failure
samoht9277
had a problem deploying
to
testing-brazil
GitHub Actions
Failure
lotuuu
previously approved these changes
Apr 9, 2024
* Rename game_backend release to main_server * Make arena_load_test release only arena_load_test app * Remove comment * Rename main_server to central_backend * Restore unintended changes --------- Co-authored-by: Nicolas Sanchez <[email protected]> Co-authored-by: Tomás Casagrande <[email protected]>
…ckend into change-release-mode
samoht9277
had a problem deploying
to
testing-brazil
GitHub Actions
Failure
samoht9277
had a problem deploying
to
testing-brazil
GitHub Actions
Failure
samoht9277
had a problem deploying
to
testing-brazil
GitHub Actions
Failure
samoht9277
had a problem deploying
to
testing-brazil
GitHub Actions
Failure
samoht9277
had a problem deploying
to
testing-brazil
GitHub Actions
Failure
samoht9277
had a problem deploying
to
testing-brazil
GitHub Actions
Failure
samoht9277
had a problem deploying
to
testing-brazil
GitHub Actions
Failure
samoht9277
had a problem deploying
to
testing-brazil
GitHub Actions
Failure
samoht9277
temporarily deployed
to
testing-brazil
GitHub Actions
Inactive
samoht9277
temporarily deployed
to
testing-brazil
GitHub Actions
Inactive
samoht9277
temporarily deployed
to
testing-europe
GitHub Actions
Inactive
samoht9277
temporarily deployed
to
testing-europe
GitHub Actions
Inactive
samoht9277
had a problem deploying
to
testing-europe
GitHub Actions
Failure
samoht9277
had a problem deploying
to
testing-brazil
GitHub Actions
Failure
samoht9277
temporarily deployed
to
testing-brazil
GitHub Actions
Inactive
samoht9277
temporarily deployed
to
testing-europe
GitHub Actions
Inactive
Nico-Sanchez
approved these changes
Apr 9, 2024
lotuuu
approved these changes
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to facilitate the deploying sequence on each individual server.
By removing the abiity to choose what release to deploy, there is no possible confusion while deploying a certain release, since this PR no longer supports the ability to choose the deploy.