fix: added MAXIMUM_GOSSIP_CLOCK_DISPARITY into account to distinguish future slots #1316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
After various tests, I've spotted no more warnings related to blocks being received a couple of milliseconds before. while still seeing them in the main branch, specially at different times of the day. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR fixes an issue where some blocks where ignored (6000656 started at 21.11.12 for us)
WARNING 21:11:11.831 [Gossip] Block ignored, reason: "Block is from the future: block.slot=6000656. Current slot: 6000655.".Description
In fact, the blocks where being received in time, just a couple of milliseconds before we made the transition, having into account
MAXIMUM_GOSSIP_CLOCK_DISPARITYin the calculation, allow us to process the block at the time.I also moved the current_slot function from
StoretoForkChoice, to have both depending on the same calculation. There is an outstanding function that previously used the oldClock.get_current_time/0that is using the system time since then, I added a comment where it is used for future reference, the function is:get_current_chain_slot/0.Resolves #1315