This repository has been archived by the owner on Oct 2, 2024. It is now read-only.
fix: eip4844 blob transactions EF tests #409
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benchmarking resultsBenchmark for program
|
| Command | Mean [s] | Min [s] | Max [s] | Relative |
|---|---|---|---|---|
evm_mlir_factorial |
2.386 ± 0.270 | 2.064 | 2.598 | 1.00 |
revm_factorial |
7.449 ± 0.951 | 7.093 | 10.155 | 3.12 ± 0.53 |
Benchmark for program fibonacci
Open benchmarks
| Command | Mean [s] | Min [s] | Max [s] | Relative |
|---|---|---|---|---|
evm_mlir_fibonacci |
2.229 ± 0.268 | 1.913 | 2.440 | 1.00 |
revm_fibonacci |
8.061 ± 0.661 | 7.770 | 9.936 | 3.62 ± 0.53 |
This is necessary because some tests don't provide the required "to" address pointed by the transaction, as they are expected to be invalid and don't actually require the account. However, the parsing of the "to" addresses is done before the validation of the transaction, resulting in a panic in `ef_tests.rs`, line 193. To fix this, a default with valid `code`, (starting with `0x`) is required. This allows tests that expect to fail to be correctly parsed before being executed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes lambdaclass/ethereum_rust#617