Rename rate to daily_rate #480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lotuuu
requested review from
AminArria,
manucamejo,
tvillegas98,
martinacantaro,
mgrunwaldt,
ncontinanza,
saugon,
marco-paulucci,
agustinesco,
tkz00,
Nico-Sanchez,
AngieDutra and
alfopisano
as code owners
lotuuu
added
the
Waiting on PR
tkz00
requested changes
Jun 7, 2024
tkz00
requested changes
Jun 7, 2024
tkz00
approved these changes
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be merged with lambdaclass/mirra_backend#668
Motivation
Updates protobuf messages to sync them with the backend PR
Summary of changes
Rename protobuf message, inner class and all occurrences of rate to daily_rate
How has this been tested?
Go through a basic game loop through the client.