Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(web): support function editor with lsp #1657

Merged
merged 49 commits into from
Jan 5, 2024
Merged

feat(web): support function editor with lsp #1657

merged 49 commits into from
Jan 5, 2024

Conversation

newfish-cmyk
Copy link
Contributor

No description provided.

@sweep-ai Sweep AI
Copy link

sweep-ai bot commented Nov 8, 2023

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.

@0fatal 0fatal marked this pull request as ready for review November 9, 2023 02:49
0fatal
0fatal previously approved these changes Nov 9, 2023
View reviewed changes
web/src/components/Editor/TextModel.tsx Outdated Show resolved Hide resolved
0fatal
0fatal previously approved these changes Nov 9, 2023
View reviewed changes
@github-actions GitHub Actions
Copy link

💥 laf nodejs runtime image built successfully for pr 1657

ghcr.io/labring/runtime-node:pr-1657
docker.io/lafyun/runtime-node:pr-1657

digest: sha256:01640b419bb9a7e20f9914e01b6d3a9d024425437872136cd3fafbcd00803944

@maslow maslow merged commit d7d0b46 into labring:main Jan 5, 2024
3 checks passed
maslow added a commit that referenced this pull request Jan 5, 2024
@maslow
Revert "feat(web): support function editor with lsp (#1657)"
61c355a 
This reverts commit d7d0b46.
@maslow maslow mentioned this pull request Jan 5, 2024
Merged
maslow added a commit that referenced this pull request Jan 5, 2024
@maslow
Revert "feat(web): support function editor with lsp (#1657)" (#1783)
5a63468 
This reverts commit d7d0b46.
@newfish-cmyk newfish-cmyk deleted the test/ts-editor branch January 16, 2024 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maslow maslow maslow approved these changes

@0fatal 0fatal 0fatal left review comments

Assignees
No one assigned
Labels
size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@newfish-cmyk @maslow @0fatal