Skip to content

Commit

Permalink
chore: Add TODO marks
Browse files Browse the repository at this point in the history
  • Loading branch information
jopemachine committed Sep 30, 2024
1 parent f4a8439 commit 85e61a6
Show file tree
Hide file tree
Showing 8 changed files with 18 additions and 3 deletions.
10 changes: 9 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -100,9 +100,13 @@ First bootstrap the cluster that contains the leader node.
let raft_addr = "127.0.0.1:60061".to_owned();
let node_id = 1;

let log_storage = HeedStorage::create(&storage_pth, &raft_config.clone(), logger.clone())
.expect("Failed to create heed storage");

let raft = Raft::bootstrap(
node_id,
raft_addr,
log_storage,
store.clone(),
raft_config,
logger.clone(),
Expand All @@ -125,16 +129,20 @@ let raft_addr = "127.0.0.1:60062".to_owned();
let peer_addr = "127.0.0.1:60061".to_owned();
let join_ticket = Raft::request_id(raft_addr, peer_addr).await;

let log_storage = HeedStorage::create(&storage_pth, &raft_config.clone(), logger.clone())
.expect("Failed to create heed storage");

let raft = Raft::bootstrap(
join_ticket.reserved_id,
raft_addr,
log_storage,
store.clone(),
raft_config,
logger.clone(),
)?;

let raft_handle = tokio::spawn(raft.clone().run());
raft.join_cluster(vec![join_ticket]).await;
raft.join_cluster(vec![join_ticket]).await?;

// ...
tokio::try_join!(raft_handle)?;
Expand Down
4 changes: 3 additions & 1 deletion binding/python/examples/cli/README.md
Original file line number Diff line number Diff line change
@@ -1 +1,3 @@
Sample doc for raftify-py CLI module
Sample doc for `raftify-py` CLI module

TODO: Write this (Ref: examples/memstore/README.md)
2 changes: 1 addition & 1 deletion binding/python/examples/cli/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ def get_requirements(env: str = None):
setup(
name="raftify_cli",
version=VERSION,
description="Experimental Async Raft framework for Python application",
description="Experimental High level Raft framework",
long_description=README,
long_description_content_type='text/markdown',
author="Lablup Inc.",
Expand Down
1 change: 1 addition & 0 deletions binding/python/examples/client/README.md
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
TODO: Write simple description how to test client script.
1 change: 1 addition & 0 deletions binding/python/tests/leader_election.py
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
# TODO: Write this.
1 change: 1 addition & 0 deletions examples/memstore/README.md
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
TODO: Write this.
1 change: 1 addition & 0 deletions examples/memstore/dynamic-members/test-cluster.sh
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
#!/bin/bash
# TODO: Write this.

echo ""
1 change: 1 addition & 0 deletions examples/memstore/static-members/test-cluster.sh
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
#!/bin/bash
# TODO: Write this.

echo ""

0 comments on commit 85e61a6

Please sign in to comment.