feat: move to detail page after modifying model service #2724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your org requires the Graphite merge queue for merging into mainAdd the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @agatha197 and the rest of your teammates on |
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🔴 | Statements | 5.41% | 338/6246 |
| 🔴 | Branches | 4.93% (+0% 🔼) |
214/4342 |
| 🔴 | Functions | 3.07% | 63/2053 |
| 🔴 | Lines | 5.31% | 324/6101 |
Test suite run success
90 tests passing in 11 suites.
Report generated by 🧪jest coverage report action from dee2f78
agatha197
added
area:ux
Graphite App
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
This PR modifies the navigation behavior after updating an endpoint in the Service Launcher page. Instead of redirecting to the general '/serving' page, it now navigates to the specific endpoint details page using the endpoint's ID.
Rationale:
This change improves the user experience by directly taking users to the relevant endpoint details after updating, rather than to a general serving page. This allows for immediate access to the newly updated endpoint's information.
Effects:
Users will now be automatically redirected to the specific endpoint details page after updating an endpoint, providing a more seamless and intuitive workflow.
How to test:
Test list:
Checklist: