fix: object merging with mutation in VFolderTable, hooks, and SessionLauncherPage #2699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your org requires the Graphite merge queue for merging into mainAdd the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🔴 | Statements | 5.47% | 337/6157 |
| 🔴 | Branches | 5.06% | 214/4232 |
| 🔴 | Functions | 3.11% | 63/2023 |
| 🔴 | Lines | 5.37% | 323/6013 |
Test suite run success
90 tests passing in 11 suites.
Report generated by 🧪jest coverage report action from 9d0dd72
Merge activity
|
…LauncherPage (#2699) ### TL;DR Modified `_.merge()` calls to include an empty object as the first argument. This PR fixed a bug where the user could not turn on the "Use automatic OpenMP optimization" option after turning it off in the Neo Session Launcher.  ### What changed? Updated three instances of `_.merge()` function calls in different files: 1. In `VFolderTable.tsx`, added an empty object as the first argument to `mergedVFolderPermissions`. 2. In `backendai.tsx`, added an empty object as the first argument when merging `deviceMetadata` and `resourceSlots`. 3. In `SessionLauncherPage.tsx`, added an empty object as the first argument when merging `INITIAL_FORM_VALUES` and `formValuesFromQueryParams`. ### Why make this change? The addition of an empty object as the first argument in `_.merge()` calls ensures that the original objects are not modified during the merge operation. This prevents potential side effects and maintains the immutability of the source objects, leading to more predictable and safer code behavior.
lizable
force-pushed
the
fix/lodash-merge-without-mutation
branch
from
3ebce15
to
9d0dd72
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Modified
_.merge()calls to include an empty object as the first argument.This PR fixed a bug where the user could not turn on the "Use automatic OpenMP optimization" option after turning it off in the Neo Session Launcher.
What changed?
Updated three instances of
_.merge()function calls in different files:VFolderTable.tsx, added an empty object as the first argument tomergedVFolderPermissions.backendai.tsx, added an empty object as the first argument when mergingdeviceMetadataandresourceSlots.SessionLauncherPage.tsx, added an empty object as the first argument when mergingINITIAL_FORM_VALUESandformValuesFromQueryParams.Why make this change?
The addition of an empty object as the first argument in
_.merge()calls ensures that the original objects are not modified during the merge operation. This prevents potential side effects and maintains the immutability of the source objects, leading to more predictable and safer code behavior.