fix: merged resource limit is affected by remaining in the resource group. #2696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your org requires the Graphite merge queue for merging into mainAdd the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
yomybaby
changed the title
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🔴 | Statements | 5.47% | 337/6156 |
| 🔴 | Branches | 5.06% (+0% 🔼) |
214/4230 |
| 🔴 | Functions | 3.11% | 63/2023 |
| 🔴 | Lines | 5.37% | 323/6012 |
Test suite run success
90 tests passing in 11 suites.
Report generated by 🧪jest coverage report action from 40b6062
yomybaby
force-pushed
the
fix/resource-limit-and-resource-group-size
branch
from
d990267
to
7b4e8e9
Compare
yomybaby
changed the title
Merge activity
|
…roup. (#2696) ### TL;DR Fixed and refactored resource limit and remaining calculations in useResourceLimitAndRemaining hook. This PR resolves the issue where the merged resource limit in useResourceLimitAndRemaining is affected by the remaining in the resource group. Now, the maximum value is determined as the minimum value of the following: - pre-container configuration (e.g., maxCPUCoresPerContainer) - keypair resource limit - group resource limit The useResourceLimitAndRemaining should consider the domain resource limit and the total slot size of the resource group. This will be handled by another PR. ### What changed? - Updated ResourceLimits type to use ResourceSlotName as key - Commented out resourceGroupResourceSize calculations for cpu and mem - Added keypair and group limits for accelerators - Updated type assertions in remaining resource calculations ### How to test? 1. Test resource allocation functionality in the UI 2. Verify that resource limits are correctly applied for different resource types (CPU, memory, accelerators) 3. Check that remaining resources are calculated accurately 4. Ensure that the changes don't introduce any regressions in resource management
yomybaby
force-pushed
the
fix/resource-limit-and-resource-group-size
branch
from
7b4e8e9
to
40b6062
Compare
graphite-app
bot
deleted the
fix/resource-limit-and-resource-group-size
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Fixed and refactored resource limit and remaining calculations in useResourceLimitAndRemaining hook.
This PR resolves the issue where the merged resource limit in useResourceLimitAndRemaining is affected by the remaining in the resource group.
Now, the maximum value is determined as the minimum value of the following:
The useResourceLimitAndRemaining should consider the domain resource limit and the total slot size of the resource group. This will be handled by another PR.
What changed?
How to test?