feat: Session owner setting panel in Neo session launcher #2693
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Your org requires the Graphite merge queue for merging into mainAdd the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
yomybaby
force-pushed
the
feat/session-owner-setter-in-neo
branch
2 times, most recently
from
730b466
to
70a922f
Compare
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🔴 | Statements | 5.28% (-0.04% 🔻) |
340/6441 |
| 🔴 | Branches | 4.77% (-0.05% 🔻) |
214/4491 |
| 🔴 | Functions | 2.97% (-0.02% 🔻) |
63/2121 |
| 🔴 | Lines | 5.18% (-0.03% 🔻) |
326/6293 |
Show new covered files 🐣
St.❔ |
File | Statements | Branches | Functions | Lines |
|---|---|---|---|---|---|
| 🔴 | ... / BAISelect.tsx |
0% | 0% | 0% | 0% |
| 🔴 | ... / HiddenFormItem.tsx |
0% | 100% | 0% | 0% |
| 🔴 | ... / SessionOwnerSetterCard.tsx |
0% | 0% | 0% | 0% |
Test suite run success
90 tests passing in 11 suites.
Report generated by 🧪jest coverage report action from c1f51bd
yomybaby
force-pushed
the
feat/session-owner-setter-in-neo
branch
from
c8adf42
to
64b9811
Compare
yomybaby
force-pushed
the
feat/session-owner-setter-in-neo
branch
from
64b9811
to
c1f51bd
Compare
| onDropdownVisibleChange={(open) => { | ||
| if (open) { | ||
| startLoadingTransition(() => { | ||
| updateFetchKey(); | ||
| }); | ||
| } | ||
| // if (open) { | ||
| // startLoadingTransition(() => { | ||
| // updateFetchKey(); | ||
| // }); | ||
| // } |
There was a problem hiding this comment.
Is there a reason you commented this out?
There was a problem hiding this comment.
The ResourceGroup does not change frequently. It is not necessary to refetch it every time the dropdown is opened.
There was a problem hiding this comment.
The User Email of the delegated session is showing as the email of the user who actually requested the creation.
Relatedly, there are cases where the user who has taken over the privileges is unable to use the control functions within the session list (running the terminal, checking logs, etc...), partly because email is registered as the creation requestor and not the user.
TL;DR
Added session owner setter functionality and improved resource group selection.
What changed?
SessionOwnerSetterCardandSessionOwnerSetterPreviewCardcomponents for setting session ownersBAISelectcomponent for enhanced select functionalityResourceGroupSelectto use project name instead of IDAvailableResourcesCardto useResourceGroupSelectForCurrentProjectSessionLauncherPageto include session owner setter for admin and superadmin rolesSessionLauncherValidationTour's errorHow to test?
Why make this change?
This change enhances the session management capabilities for administrators, allowing them to launch sessions on behalf of other users.