Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: replace svg as customIcon component #2672

Merged
merged 2 commits into from
Aug 30, 2024
Merged

Conversation

lizable
Copy link
Contributor

@lizable lizable commented Aug 29, 2024

Checklist: (if applicable)

  • Mention to the original issue
  • Documentation
  • Minium required manager version
  • Specific setting for review (eg., KB link, endpoint or how to setup)
  • Minimum requirements to check during review
  • Test case(s) to demonstrate the difference of before/after

@github-actions github-actions bot added the area:ux UI / UX issue. label Aug 29, 2024
@lizable lizable mentioned this pull request Aug 29, 2024
6 tasks
Copy link
Contributor Author

lizable commented Aug 29, 2024

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @lizable and the rest of your teammates on Graphite Graphite

@github-actions github-actions bot added the size:L 100~500 LoC label Aug 29, 2024
@lizable lizable mentioned this pull request Aug 29, 2024
6 tasks
Copy link

graphite-app bot commented Aug 29, 2024

Your org requires the Graphite merge queue for merging into main

Add the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@lizable lizable force-pushed the feat/icon-add branch 4 times, most recently from 62ecb07 to d820bd7 Compare August 29, 2024 18:46
@lizable lizable marked this pull request as ready for review August 30, 2024 05:37
@lizable lizable requested a review from agatha197 August 30, 2024 08:21
Base automatically changed from feat/apply-new-GNB to feat/publishing August 30, 2024 08:34
@agatha197 agatha197 merged commit 59375e6 into feat/publishing Aug 30, 2024
3 of 4 checks passed
@github-actions github-actions bot added size:XS ~10 LoC and removed size:L 100~500 LoC labels Aug 30, 2024
@agatha197 agatha197 deleted the feat/icon-add branch August 30, 2024 11:01
@lizable lizable mentioned this pull request Aug 30, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:ux UI / UX issue. size:XS ~10 LoC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants