-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Introduce resizable table
component
#2606
base: main
Are you sure you want to change the base?
Conversation
Your org requires the Graphite merge queue for merging into mainAdd the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @ironAiken2 and the rest of your teammates on Graphite |
c48f351
to
57f6cab
Compare
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
---|---|---|---|
🔴 | Statements | 5.39% (-0.02% 🔻) |
338/6272 |
🔴 | Branches | 4.91% (-0.01% 🔻) |
214/4357 |
🔴 | Functions | 3.05% (-0.01% 🔻) |
63/2063 |
🔴 | Lines | 5.29% (-0.02% 🔻) |
324/6125 |
Show new covered files 🐣
St.❔ |
File | Statements | Branches | Functions | Lines |
---|---|---|---|---|---|
🔴 | ... / BAITable.tsx |
0% | 0% | 0% | 0% |
Test suite run success
90 tests passing in 11 suites.
Report generated by 🧪jest coverage report action from 7dfa157
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for checking late. Please solve the conflicts
57f6cab
to
1d0492a
Compare
1d0492a
to
eb20cfc
Compare
eb20cfc
to
d1e8d1b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
22cd94b
to
b1587fb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I set the narrow width, I cannot see the part of the contents until widening that column.
By adding whiteSpace: 'pre', wordWrap: 'break-word'
to https://github.com/lablup/backend.ai-webui/pull/2606/files#diff-20fe13a09e30cb99672ad684d2c592b13f7ba6c973a8f0ec7a208195e4e3edefR22 line, you can avoid it or you can add a new line or add ellipsis, etc.
b1587fb
to
25cba76
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
25cba76
to
ce84cbf
Compare
Currently, the way vaadin tables show contents on resize is a mix of the The |
ce84cbf
to
7808bdf
Compare
7808bdf
to
7dfa157
Compare
TL;DR
Introduce BAITable, resizable table component.
What changed?
BAITable calculates and applies new widths based on a fixed width, so there are two rules to follow for smooth behavior
How to test?
Checklist: (if applicable)