-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PodMonitor Support with Metric Relabeling #4
Conversation
I've updated charts/node-local-dns/templates/serviceaccount.yaml as well to fix possible logical issues
The issue is with the --- separator at the beginning of the template combined with the conditional block {{- if .Values.serviceAccount.create -}}. If .Values.serviceAccount.create is set to false, Helm will render the template as an empty YAML file with just the --- separator, which is invalid. To fix the issue, moved the separator --- inside the conditional block |
@@ -0,0 +1,22 @@ | |||
--- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @wonderg . Thanks for this PR. It would be nice to have an option to enable/disable podmonitor
podmonitor:
enabled: true
metricRelabelings: []
....
@wonderg any news on this? I would really love to get all 3 open PR merged |
sure, please check recent commits. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @wonderg , it looks good. Just please bump the chart version to 1.6.0
in charts/node-local-dns/Chart.yaml
sure, just bumped it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks @wonderg
Description:
This PR introduces support for PodMonitor, enhancing the integration with Prometheus Operator. A key feature added is the ability to define metric relabeling configurations, giving users more flexibility in shaping the scraped metrics.
Changes include: