Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PodMonitor Support with Metric Relabeling #4

Merged
merged 10 commits into from
Dec 9, 2023

Conversation

wonderg
Copy link

@wonderg wonderg commented Sep 26, 2023

Description:

This PR introduces support for PodMonitor, enhancing the integration with Prometheus Operator. A key feature added is the ability to define metric relabeling configurations, giving users more flexibility in shaping the scraped metrics.

Changes include:

  • Updated README.md to reflect the new configurable parameter podmonitor.metricRelabelings.
  • Added a new template for PodMonitor with provisions for metric relabeling.

@wonderg
Copy link
Author

wonderg commented Oct 4, 2023

I've updated charts/node-local-dns/templates/serviceaccount.yaml as well to fix possible logical issues

[ERROR] templates/serviceaccount.yaml: unable to parse YAML: invalid Yaml document separator: apiVersion: v1

The issue is with the --- separator at the beginning of the template combined with the conditional block {{- if .Values.serviceAccount.create -}}. If .Values.serviceAccount.create is set to false, Helm will render the template as an empty YAML file with just the --- separator, which is invalid.

To fix the issue, moved the separator --- inside the conditional block

@@ -0,0 +1,22 @@
---

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @wonderg . Thanks for this PR. It would be nice to have an option to enable/disable podmonitor

podmonitor:
  enabled: true
  metricRelabelings: []
....

@mjtrangoni
Copy link

@wonderg any news on this? I would really love to get all 3 open PR merged

@wonderg
Copy link
Author

wonderg commented Dec 9, 2023

1

sure, please check recent commits.

@MonolithProjects MonolithProjects self-assigned this Dec 9, 2023
@MonolithProjects MonolithProjects added the enhancement New feature or request label Dec 9, 2023
Copy link

@MonolithProjects MonolithProjects left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @wonderg , it looks good. Just please bump the chart version to 1.6.0 in charts/node-local-dns/Chart.yaml

@wonderg
Copy link
Author

wonderg commented Dec 9, 2023

1.6.0

Hi @wonderg , it looks good. Just please bump the chart version to 1.6.0 in charts/node-local-dns/Chart.yaml

sure, just bumped it.

Copy link

@MonolithProjects MonolithProjects left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @wonderg

@MonolithProjects MonolithProjects merged commit 57bc03f into lablabs:master Dec 9, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants