Skip to content

Commit

Permalink
Merge pull request #5 from mjtrangoni/fix-helm-lint
Browse files Browse the repository at this point in the history
Fix some trivial linter issues
  • Loading branch information
MonolithProjects authored Oct 24, 2023
2 parents e23870d + 3894cd6 commit 5eb0a1d
Show file tree
Hide file tree
Showing 5 changed files with 11 additions and 11 deletions.
8 changes: 4 additions & 4 deletions .github/workflows/lint-test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -7,23 +7,23 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v2
uses: actions/checkout@v4
with:
fetch-depth: 0

- name: Run chart-testing (lint)
id: lint
uses: helm/chart-testing-action@v1.1.0
uses: helm/chart-testing-action@v2.4.0
with:
command: lint
config: ct.yaml

- name: Create kind cluster
uses: helm/kind-action@v1.7.0
uses: helm/kind-action@v1.8.0
if: steps.lint.outputs.changed == 'true'

- name: Run chart-testing (install)
uses: helm/chart-testing-action@v1.1.0
uses: helm/chart-testing-action@v2.4.0
with:
command: install
config: ct.yaml
2 changes: 1 addition & 1 deletion .github/workflows/release.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v2
uses: actions/checkout@v4
with:
fetch-depth: 0

Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

## Helm Chart Repository

```
```console
helm repo add node-local-dns https://lablabs.github.io/k8s-nodelocaldns-helm/
helm install node-local-dns/node-local-dns
```
8 changes: 4 additions & 4 deletions charts/node-local-dns/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,14 @@

## Helm Chart Repository

```
helm repo add cloudflare-exporter https://lablabs.github.io/k8s-nodelocaldns-helm/
```console
helm repo add k8s-nodelocaldns-helm https://lablabs.github.io/k8s-nodelocaldns-helm/
helm install k8s-nodelocaldns-helm/node-local-dns
```

## Configuration

This chart deploys NodeLocal DNSCache Daemon set according to https://kubernetes.io/docs/tasks/administer-cluster/nodelocaldns/.
This chart deploys NodeLocal DNSCache Daemon set according to <https://kubernetes.io/docs/tasks/administer-cluster/nodelocaldns/>.

It is designed to work both with iptables and IPVS setup.

Expand Down Expand Up @@ -143,4 +143,4 @@ config:
}
```
https://github.com/kubernetes/kubernetes/blob/master/cluster/addons/dns/nodelocaldns/nodelocaldns.yaml
Reference [node-local-dns upstream](https://github.com/kubernetes/kubernetes/blob/master/cluster/addons/dns/nodelocaldns/nodelocaldns.yaml)
2 changes: 1 addition & 1 deletion charts/node-local-dns/templates/serviceaccount.yaml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
---
{{- if .Values.serviceAccount.create -}}
{{- if .Values.serviceAccount.create }}
apiVersion: v1
kind: ServiceAccount
metadata:
Expand Down

0 comments on commit 5eb0a1d

Please sign in to comment.