Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove kuttl deletion step #751

Closed
wants to merge 2 commits into from
Closed

chore: remove kuttl deletion step #751

wants to merge 2 commits into from

Conversation

realshuting
Copy link
Member

No description provided.

@realshuting
remove delete step
f310597 
Signed-off-by: ShutingZhao <[email protected]>
@chipzoller chipzoller self-requested a review September 13, 2023 11:46
@chipzoller
Copy link
Contributor

Let's confirm kuttl finishes successfully on this run.

@chipzoller chipzoller self-requested a review September 13, 2023 12:27
chipzoller
chipzoller suggested changes Sep 13, 2023
View reviewed changes
Copy link
Contributor

@chipzoller chipzoller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We must retain this deletion step because the policy is created in a non-conventional way which sets Enforce mode using sed.

@realshuting
Copy link
Member Author

Seems like this change caused more failures.

The cleanup task caused timeout, can we do them in separated steps? i.e., delete the pod first, wait 3s then delete the namespace?

@chipzoller
Copy link
Contributor

Yes, the cleanups can be done in different tasks, but we still have to delete the policy which is why this was causing failures.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chipzoller chipzoller chipzoller requested changes

@eddycharly eddycharly Awaiting requested review from eddycharly

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@realshuting @chipzoller