chore: Make managed-by label value transparent

[nesmabadr]

Description

Changes proposed in this pull request:

• Change managed by label to kyma instead of lifecycle-manager and declarative-v2 for SKR resources

Related issue(s)
Resolves #1821

[c-pius]

I found the following resources that seem to missing the label:

  apiVersion: v1
  kind: Service
  metadata:
    creationTimestamp: "2024-09-30T11:21:49Z"
    name: skr-webhook-metrics
    namespace: kyma-system
    resourceVersion: "594"
    uid: 5d8db776-d102-404b-a46e-6fe17bf22f6f
  spec:
    clusterIP: 10.43.161.169
    clusterIPs:
    - 10.43.161.169
    internalTrafficPolicy: Cluster
    ipFamilies:
    - IPv4
    ipFamilyPolicy: SingleStack
    ports:
    - name: http-metrics
      port: 2112
      protocol: TCP
      targetPort: metrics-port
    selector:
      app: skr-webhook
    sessionAffinity: None
    type: ClusterIP
  status:
    loadBalancer: {}
---
apiVersion: v1
kind: Service
metadata:
  creationTimestamp: "2024-09-30T11:21:49Z"
  name: skr-webhook-metrics
  namespace: kyma-system
  resourceVersion: "594"
  uid: 5d8db776-d102-404b-a46e-6fe17bf22f6f
spec:
  clusterIP: 10.43.161.169
  clusterIPs:
  - 10.43.161.169
  internalTrafficPolicy: Cluster
  ipFamilies:
  - IPv4
  ipFamilyPolicy: SingleStack
  ports:
  - name: http-metrics
    port: 2112
    protocol: TCP
    targetPort: metrics-port
  selector:
    app: skr-webhook
  sessionAffinity: None
  type: ClusterIP
status:
  loadBalancer: {}
---
  apiVersion: v1
  items:
  - apiVersion: operator.kyma-project.io/v1alpha1
    kind: Sample
    metadata:
      creationTimestamp: "2024-09-30T11:26:00Z"
      finalizers:
      - sample.kyma-project.io/finalizer
      generation: 1
      name: sample-yaml
      namespace: kyma-system
      resourceVersion: "783"
      uid: d90013b9-e90c-4205-85dc-23122a1be6c6
    spec:
      resourceFilePath: ./module-data/yaml
    status:
      conditions:
      - lastTransitionTime: "2024-09-30T11:26:01Z"
        message: installation is ready and resources can be used
        observedGeneration: 1
        reason: Ready
        status: "True"
        type: Installation
      state: Ready
  kind: List
  metadata:
    resourceVersion: ""
---
  apiVersion: v1                             
  kind: ServiceAccount                       
    metadata:                                
    creationTimestamp: "2024-09-30T11:25:58Z"
    name: default                            
    namespace: template-operator-system      
    resourceVersion: "735"                   
    uid: 35585fc0-924a-4f37-85d2-ffc5a7cc288f
---

Do we also have documentation on the label that may need to be changed?

[c-pius]

It bugs me a bit that Go is so verbose here... Not a problem with your implementation but the language... Should we at least introduce a helper func that merges two sets of labels so that we don't have to the same logic 3 times?

Something like

func mergeMaps(map1, map2 map[string]string) map[string]string {
    mergedMap := make(map[string]string)

    for k, v := range map1 {
        mergedMap[k] = v
    }

    for k, v := range map2 {
        mergedMap[k] = v
    }

    return mergedMap
}

// usage

crdToApply.SetLabels(mergeMaps(crdToApply.GetLabels(), map[string]string{
	shared.ManagedBy: shared.KymaLabelValue,
}))

I also played around with maps.Copy std func but that one fails if the destination map is nil which could be the case for us. Ideally, we could also make the mergeMaps func generic instead of string string.

WDYT?

[c-pius]

+1 on the map topic

[c-pius]

+1 on the map topic

[c-pius]

Just noticed this would be another +1 for the merge maps