Skip to content

feat: Zero downtime runtime watcher tls management #3509

feat: Zero downtime runtime watcher tls management

feat: Zero downtime runtime watcher tls management #3509

Triggered via pull request September 16, 2024 17:57
Status Failure
Total duration 4m 19s
Artifacts

lint-golangci.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

10 errors and 1 warning
lint: cmd/main.go#L186
Magic number: 8, in <argument> detected (mnd)
lint: cmd/main.go#L501
commentFormatting: put a space between `//` and comment text (gocritic)
lint: cmd/main.go#L504
commentFormatting: put a space between `//` and comment text (gocritic)
lint: cmd/main.go#L516
Comment should end in a period (godot)
lint: cmd/main.go#L518
Magic number: 0.1, in <argument> detected (mnd)
lint: cmd/main.go#L521
Comment should end in a period (godot)
lint: cmd/main.go#L526
Comment should end in a period (godot)
lint: cmd/main.go#L528
G404: Use of weak random number generator (math/rand or math/rand/v2 instead of crypto/rand) (gosec)
lint: pkg/watcher/certificate_manager.go#L28
ST1003: const TlsCertKey should be TLSCertKey (stylecheck)
lint: pkg/watcher/certificate_manager.go#L29
ST1003: const TlsPrivateKeyKey should be TLSPrivateKeyKey (stylecheck)
lint
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/setup-go@v4. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/