Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.5] hotfix: Disable new behaviour for ENABLE_EXTERNAL_NAME_ALIAS #789

Merged
merged 13 commits into from
May 2, 2024
Merged

[release-1.5] hotfix: Disable new behaviour for ENABLE_EXTERNAL_NAME_ALIAS #789

merged 13 commits into from
May 2, 2024

Conversation

barchw
Copy link
Collaborator

@barchw barchw commented May 2, 2024

Description

Changes proposed in this pull request:

  • Disable new behaviour for ENABLE_EXTERNAL_NAME_ALIAS

Related issues

@kyma-bot kyma-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 2, 2024
@kyma-bot
Copy link
Contributor

kyma-bot commented May 2, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 2, 2024
@barchw barchw mentioned this pull request May 2, 2024
Closed
@barchw barchw changed the title [1.5] hotfix: Disable new behaviour for ENABLE_EXTERNAL_NAME_ALIAS [release-1.5] hotfix: Disable new behaviour for ENABLE_EXTERNAL_NAME_ALIAS May 2, 2024
@kyma-bot kyma-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 2, 2024
@kyma-bot kyma-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 2, 2024
@barchw barchw marked this pull request as ready for review May 2, 2024 13:03
@barchw barchw requested review from a team as code owners May 2, 2024 13:03
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 2, 2024
triffer
triffer reviewed May 2, 2024
View reviewed changes
docs/release-notes/1.7.0.md Outdated Show resolved Hide resolved
triffer
triffer reviewed May 2, 2024
View reviewed changes
docs/release-notes/1.6.1.md Outdated Show resolved Hide resolved
@triffer triffer self-requested a review May 2, 2024 13:46
triffer
triffer previously approved these changes May 2, 2024
View reviewed changes
@kyma-bot kyma-bot added the lgtm Looks good to me! label May 2, 2024
@kyma-bot kyma-bot removed the lgtm Looks good to me! label May 2, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label May 2, 2024
@kyma-bot kyma-bot merged commit b868da5 into kyma-project:release-1.5 May 2, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nataliasitko nataliasitko nataliasitko approved these changes

@triffer triffer triffer left review comments

Assignees

@triffer triffer

@nataliasitko nataliasitko

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@barchw @kyma-bot @triffer @nataliasitko @kolodziejczak