Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is this really necessary in 2018 #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

whomwah
Copy link
Member

@whomwah whomwah commented Sep 21, 2018

A bit of research shows the rule came off the back of IBM punch cards and then teletypes and video terminals in the 1970's https://en.wikipedia.org/wiki/Punched_card#I

@whomwah whomwah self-assigned this Sep 21, 2018
@nicklinnell
Copy link
Member

@whomwah The only problem is I think rubcop defaults to 80 so this doesn't change anything

@atothewest
Copy link

I quite like a limit as it does help keep things tidy, but agree that 80 feels a bit extreme nowadays. I've been using 100 on a few projects and like it.

@whomwah
Copy link
Member Author

whomwah commented Sep 26, 2018

Feels like all the other rules would sort the line limit out. Maybe like @atothewest says, we set it to something high, so there's a hint but it's not going to mean there are # rubocop:disable comments everywhere.

@nicklinnell
Copy link
Member

100 does fell like a more sensible limit to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants