Handle transitive calls from a nonexclusive method #719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xThaid
approved these changes
Jul 3, 2024
piotro888
reviewed
Jul 4, 2024
transactron/core/manager.py
Outdated
Comment on lines
156
to
161
| if ( | ||
| transaction1 is not transaction2 | ||
| and not transactions_exclusive(transaction1, transaction2) | ||
| and method in method_map.exclusive_methods_by_transaction[transaction1] | ||
| and method in method_map.exclusive_methods_by_transaction[transaction2] | ||
| ): |
There was a problem hiding this comment.
In the case like
T1 ------------------------> NORMAL
T2 -> NONEXCLUSIVE ---------/
T1 should conflict with T2. But because NORMAL is not in the exclusive_methods_by_transaction[T2], it doesn't. I modified the tests, and both transactions execute at the same time. Am I doing/understanding something incorrectly, or there is a problem?
There was a problem hiding this comment.
There is a problem, thanks for noticing that.
tilk
force-pushed
the
tilk/nonexclusive-transitivity
branch
from
0d5b4b8
to
68c00bb
Compare
lekcyjna123
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #717.