Add def_one_caller_wrapper #536
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 15, 2023 15:24
|
Do we need this anywhere now? Isn't a function returning a module something weird? |
|
I have the plan to port switching networks from #395 and it is needed there. |
tilk
reviewed
Dec 15, 2023
| @@ -250,3 +251,37 @@ def elaborate(self, platform): | |||
| m.submodules[f"ManyToOneConnectTrans_input_{i}"] = ConnectTrans(self.m_put_result, self.get_results[i]) | |||
|
|
|||
| return m | |||
|
|
|||
|
|
|||
| def def_one_caller_wrapper(method_to_wrap: Method, wrapper: Method) -> TModule: | |||
There was a problem hiding this comment.
Why isn't this an Elaboratable (or, alternatively, why does this not have a module argument)? It's kinda weird in Amaranth to return a module from a function.
tilk
reviewed
Dec 15, 2023
| raise ValueError("def_one_caller_wrapper support only wrapping of methods which don't return data.") | ||
|
|
||
| m = TModule() | ||
| buffer = FIFO(method_to_wrap.data_in.layout, 2) |
There was a problem hiding this comment.
Maybe the connector should be parametrized?
tilk
reviewed
Dec 18, 2023
| @@ -8,6 +8,7 @@ | |||
| "Connect", | |||
| "ConnectTrans", | |||
| "ManyToOneConnectTrans", | |||
| "def_one_caller_wrapper", | |||
There was a problem hiding this comment.
Rename one to single, to be consistent with Transactron core.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ports from #395 a
def_one_caller_wrapper. Function which is a syntax sugar for introducing a Fifo which collect all incoming data and pass them to the one_caller method.Examples of usage:
coreblocks/coreblocks/fu/vector_unit/v_executor.py
Line 109 in ddb21b5
coreblocks/coreblocks/transactions/lib.py
Line 1444 in ddb21b5