Priority ordering proxy #355
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tilk
reviewed
May 22, 2023
coreblocks/transactions/lib.py
Outdated
Comment on lines
896
to
906
| with Transaction().body(m): | ||
| with condition(m, priority=True) as branch: | ||
| for k in range(len(self.m_unordered), 0, -1): | ||
| for comb_un in itertools.combinations(self._m_unordered_read, k): | ||
| with branch(1): # sic! | ||
| branch_trans = TransactionBase.get() | ||
| for un, ord in zip(comb_un, self.m_ordered): | ||
| trans_mod = ConnectTrans(un, ord) | ||
| trans_mod.t_elaborate() | ||
| m.submodules += trans_mod | ||
| branch_trans.simultaneous(trans_mod.transaction) |
There was a problem hiding this comment.
How is this different from just creating multiple transactions?
There was a problem hiding this comment.
If I understand things correctly, what this whole thing does is:
- It gender-changes the input, so that you provide methods. instead of taking methods. (We didn't do this consequently before, but I'd prefer to externalize gender-changing if possible. In other words, first create an Elaboratable which has the most natural interface for it, and then provide gender-changed variants if possible.)
- For each subsequence of the input methods, it creates a transaction which connects N first methods from
m_orderedto the methods from the subsequence. Also, these transactions are ordered.
My remarks are:
- The use of simultaneous transactions is completely unneeded for the point 2 above. You are creating a lot of work for the transaction manager, even though you could easily express this directly - and it would probably be more readable, too. Edit: I kind of see your point. What you really want is something kind of like
condition, but without the base transaction. Maybe it's possible to modifyconditionto achieve that? Needs to be investigated. This thing imposes too much ordering. If I understand correctly, you actually want the largest subsequences to be ordered before the smallest. This is a weaker, non-linear ordering.Edit: The ordering of the subsequences is probably important for you, too, I'm retracting this remark.- Creating ConnectTrans just to mess with its insides later is very ugly. I understand you wanted to avoid repeating these four lines inside
ConnectTrans, but this definitely is a very convoluted way to do this. An alternative would be, for example, to create a function which does this, and use it both inConnectTransand here. (We currently don't have a simple way to compose transactions like you would want. The way you proposed is weirdly convoluted and certainly not the way to go.)
tilk
reviewed
May 22, 2023
added 2 commits
June 5, 2023 18:24
|
Moved to #395 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is a PR which create a method ordering proxy. It will be next used in MultiportFifo to order calls on transactron level (instead of ordering on coreblock logic level). Both
with conditionandConnectwere useful in this PR.This depends on: #304
#347