fix PR comments 1

kutluhanmetin · Aug 28, 2023 · 14bd37b · 14bd37b
1 parent 26112da
commit 14bd37b
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 6 deletions.
diff --git a/base/commands/script.go b/base/commands/script.go
@@ -72,7 +72,7 @@ func (cm ScriptCommand) Exec(ctx context.Context, ec plug.ExecContext) error {
 	verbose := ec.Props().GetBool(clc.PropertyVerbose)
 	ie := ec.Props().GetBool(flagIgnoreErrors)
 	echo := ec.Props().GetBool(flagEcho)
-	textFn := makeTextFunc(m, ec, verbose, func(shortcut string) bool {
+	textFn := makeTextFunc(m, ec, verbose, false, false, func(shortcut string) bool {
 		// shortcuts are not supported in the script mode
 		return false
 	})

diff --git a/base/commands/shell.go b/base/commands/shell.go
@@ -80,7 +80,7 @@ func (cm *ShellCommand) ExecInteractive(ctx context.Context, ec plug.ExecContext
 	}
 	verbose := ec.Props().GetBool(clc.PropertyVerbose)
 	endLineFn := makeEndLineFunc()
-	textFn := makeTextFunc(m, ec, verbose, func(shortcut string) bool {
+	textFn := makeTextFunc(m, ec, verbose, false, false, func(shortcut string) bool {
 		cm.mu.RLock()
 		_, ok := cm.shortcuts[shortcut]
 		cm.mu.RUnlock()

diff --git a/base/commands/shell_script_common.go b/base/commands/shell_script_common.go
@@ -47,7 +47,7 @@ func makeEndLineFunc() shell.EndLineFn {
 	}
 }
 
-func makeTextFunc(m *cmd.Main, ec plug.ExecContext, verbose bool, sf shortcutFunc) shell.TextFn {
+func makeTextFunc(m *cmd.Main, ec plug.ExecContext, verbose, ignoreErrors, echo bool, sf shortcutFunc) shell.TextFn {
 	return func(ctx context.Context, stdout io.Writer, text string) error {
 		if strings.HasPrefix(strings.TrimSpace(text), shell.CmdPrefix) {
 			parts := strings.Fields(text)

diff --git a/clc/shell/common.go b/clc/shell/common.go
@@ -91,8 +91,8 @@ func ConvertStatement(ctx context.Context, ec plug.ExecContext, stmt string, ver
 func InteractiveHelp() string {
 	return `
 Shortcut Commands:
-	\di			  List Indexes
-	\di	 MAPPING  List Indexes for a specific mapping
+	\di           List Indexes
+	\di  MAPPING  List Indexes for a specific mapping
 	\dm           List mappings
 	\dm  MAPPING  Display information about a mapping
 	\dm+ MAPPING  Describe a mapping

diff --git a/internal/proto/codec/builtin.go b/internal/proto/codec/builtin.go
@@ -268,7 +268,7 @@ func DecodeListMultiFrameForData(frameIterator *proto.ForwardFrameIterator) []*i
 }
 
 func DecodeListMultiFrameForIndexConfig(frameIterator *proto.ForwardFrameIterator) []types.IndexConfig {
-	result := make([]types.IndexConfig, 0)
+	var result []types.IndexConfig
 	if frameIterator.HasNext() {
 		frameIterator.Next()