Added default jmeter.properties to the plugin #47
Conversation
|
I assume that a jmeter.properties file that you put in $srcDir/jmeter.properties will get copied into $projectDir/build/jmeter at runtime? If so, this sounds correct. |
|
@djangofan no, if plugin user does not set jmeterPropertyFile, then I'm defaulting to using the jmeter.properties that ships with jmeter version 2.13. Should I expect that there is always a jmeter.properties in srcDir? |
|
Ok, made another change based on what you said. Which jmeter.properties to use is now determined in this order:
|
|
@kulya can you please accept this pull-req or suggest any changes you want made? |
| @@ -229,6 +248,7 @@ private String executeJmeterTest(String fileLocation) { | |||
| specs.getSystemProperties().put("saveservice_properties", System.getProperty("saveservice_properties")); | |||
| specs.getSystemProperties().put("upgrade_properties", System.getProperty("upgrade_properties")); | |||
| specs.getSystemProperties().put("log_file", System.getProperty("log_file")); | |||
| specs.getSystemProperties().put("jmeter.save.saveservice.output_format","xml"); | |||
There was a problem hiding this comment.
is this necessary, as i recall this used to be in the jmeter.properties file.
There was a problem hiding this comment.
This is the line in jmeter.properties (it is commented out)
#jmeter.save.saveservice.output_format=csv
which implies that the default format is xml. But for some reason, when using this plugin to run a jmeter test, the results are in csv format. see #45. I added this line to remedy that.
generation. For now it generates all the reports. - Bumped version number.
existing project declares the plugins we will remove the in built ones.
- Make the extension optional, so the optional jars are only added when needed. - Undid some layout changes. - Updated documentation.
Conflicts: src/main/groovy/com/github/kulya/gradle/plugins/jmeter/JmeterAbstractTask.groovy
Conflicts: build.gradle src/main/groovy/com/github/kulya/gradle/plugins/jmeter/JmeterPluginConvention.java src/main/groovy/com/github/kulya/gradle/plugins/jmeter/JmeterRunTask.java
Conflicts: build.gradle src/main/groovy/com/github/kulya/gradle/plugins/jmeter/JmeterAbstractTask.groovy
Added default jmeter.properties from jmeter 2.13 into plugin.
jmeterPropertyFile, this value is used as jmeter properties$projectDir/build/jmeteris usedSet property
jmeter.save.saveservice.output_format=xmlin jmeterRun task, so results files are in xml format and can be transformed to HTML files for reports.