[Feature] Add a Filter plugin to ensure that non-GPU pods are not sch…

[Zeel-Patel]

…eduled on GPU nodes

This plugin is widely being used at Uber and thought can be useful for open source community.

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

[k8s-ci-robot]

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[k8s-ci-robot]

Welcome @Zeel-Patel!

It looks like this is your first PR to kubernetes-sigs/scheduler-plugins 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/scheduler-plugins has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @Zeel-Patel. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Zeel-Patel
Once this PR has been reviewed and has the lgtm label, please assign huang-wei for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[netlify]

✅ Deploy Preview for kubernetes-sigs-scheduler-plugins canceled.

Name	Link
🔨 Latest commit	e90d648
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-sigs-scheduler-plugins/deploys/66ab75bc3df1320008b23a0b

[PiotrProkop]

I think we should move both of those values so they can be changed via configuration file. Some clusters may also have more than one gpu resource on the node, so it would be great if we could provide a list of gpu resources.

[googs1025]

+1, Using configuration files is better than hard-coding. Maybe we don't need to limit ourselves to GPU resources, can we extend it to different resources?

[PiotrProkop]

Overall I think this could be a generic plugin that filters out pod not requesting some specific resource from nodes advertising those resources with except for device-plugin of dra-plugin(in the future).

[googs1025]

/ok-to-test

[k8s-ci-robot]

@Zeel-Patel: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-scheduler-plugins-verify	e90d648	link	true	/test pull-scheduler-plugins-verify

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[googs1025]

Can we have a KEP document?

[Zeel-Patel]

Sure, let me write a KEP doc first

[googs1025]

/kind feature

[Zeel-Patel]

Overall I think this could be a generic plugin that filters out pod not requesting some specific resource from nodes advertising those resources with except for device-plugin of dra-plugin(in the future).

@PiotrProkop sure, can you provide more info on what you mean by
except fordevice-pluginofdra-plugin(in the future).

[PiotrProkop]

Overall I think this could be a generic plugin that filters out pod not requesting some specific resource from nodes advertising those resources with except for device-plugin of dra-plugin(in the future).

@PiotrProkop sure, can you provide more info on what you mean by except fordevice-pluginofdra-plugin(in the future).

Same idea what this func does:

func containsNvidiaDevicePluginImage(containerList []v1.Container) bool {
	for _, containerItem := range containerList {
		if strings.Contains(containerItem.Image, devicePluginContainerImage) {
			return true
		}
	}
	return false
}

make this filter plugin not fail device-plugins that provides given resource for other pods :)

[ffromani]

/cc

+1 for having a design document/KEP
I'm interested in this topic

[ffromani]

Overall I think this could be a generic plugin that filters out pod not requesting some specific resource from nodes advertising those resources with except for device-plugin of dra-plugin(in the future).

strong agree. It seems there is a easy (and safe?) generalization path for this filter plugin. We can have allowlist/denylist in the plugin.
But I wonder if the same functionality can be achieved using existing scheduling tools. On top of my head: taints/tolerations? What extra value a filter plugin will bring?