Add a BaseWebhook that replaces all kubeflow webhooks #3102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
k8s-ci-robot
added
approved
✅ Deploy Preview for kubernetes-sigs-kueue canceled.
|
alculquicondor
force-pushed
the
base-webhook
branch
2 times, most recently
from
b44c458
to
28d2e22
Compare
k8s-ci-robot
added
size/XXL
Change-Id: Ia6343aa06900654011dec92ff4136b8c2deeaf3f
alculquicondor
force-pushed
the
base-webhook
branch
from
28d2e22
to
8d04237
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alculquicondor The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
size/XL
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 313e1f5f3a611c46ce7521e4083f8aa89ee30b5c
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Introduce a BaseWebhook that can be used as-is for most job integrations. This removes a lot of repeated code for kubeflow.
Which issue(s) this PR fixes:
I did this in preparation for #2878
It can also justify the removal of integration tests for most kubeflow jobs #2993
Special notes for your reviewer:
Does this PR introduce a user-facing change?