Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests] Add ginkgo tests time analysis #3035

Merged
merged 2 commits into from
Sep 13, 2024

Conversation

trasc
Copy link
Contributor

@trasc trasc commented Sep 12, 2024

What type of PR is this?

/kind feature

What this PR does / why we need it:

Adds a way to analyse the time consumption of the ginkgo based tests (integration and e2e).

The test are now exporting the json report which is then processed by a small tool which lists the test specs in reverse order of the time taken by them to complete, for example integration-top.yaml

Which issue(s) this PR fixes:

Relates to #2993

Special notes for your reviewer:

Does this PR introduce a user-facing change?

None

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Sep 12, 2024
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 12, 2024
@trasc
Copy link
Contributor Author

trasc commented Sep 12, 2024

/test all

Copy link

netlify bot commented Sep 12, 2024

Deploy Preview for kubernetes-sigs-kueue canceled.

Name Link
🔨 Latest commit a2f0434
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/66e422c912ebe1000882138f

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 12, 2024
@trasc
Copy link
Contributor Author

trasc commented Sep 12, 2024

/test all

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Sep 13, 2024
@trasc trasc marked this pull request as ready for review September 13, 2024 06:57
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 13, 2024
Copy link
Contributor

@mimowo mimowo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall. I would just suggest to simplify and drop arguments we don't use for now.

I'm wondering which layer produces the (INVALID NODE TYPE) in multiple test cases, and what is its meaning?

hack/internal/tools/ginkgo-top/ginkgo-top.go Outdated Show resolved Hide resolved
hack/internal/tools/ginkgo-top/ginkgo-top.go Outdated Show resolved Hide resolved
Copy link
Contributor Author

@trasc trasc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would just suggest to simplify and drop arguments we don't use for now.

I am using the two arguments in local runs.

I'm wondering which layer produces the (INVALID NODE TYPE) in multiple test cases, and what is its meaning?

Mainly the body of ginkgo.By blocks.

hack/internal/tools/ginkgo-top/ginkgo-top.go Outdated Show resolved Hide resolved
hack/internal/tools/ginkgo-top/ginkgo-top.go Outdated Show resolved Hide resolved
@mimowo
Copy link
Contributor

mimowo commented Sep 13, 2024

I am using the two arguments in local runs.

I see, sgtm

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 13, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mimowo, trasc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: ebf9b8fc60ff358c4e771d24447d58f201afc537

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 13, 2024
@k8s-ci-robot k8s-ci-robot merged commit ccf57f1 into kubernetes-sigs:main Sep 13, 2024
16 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v0.9 milestone Sep 13, 2024
@trasc trasc deleted the ginkgo-top branch September 13, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants