-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tests] Add ginkgo tests time analysis #3035
Conversation
Skipping CI for Draft Pull Request. |
/test all |
✅ Deploy Preview for kubernetes-sigs-kueue canceled.
|
/test all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall. I would just suggest to simplify and drop arguments we don't use for now.
I'm wondering which layer produces the (INVALID NODE TYPE)
in multiple test cases, and what is its meaning?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would just suggest to simplify and drop arguments we don't use for now.
I am using the two arguments in local runs.
I'm wondering which layer produces the (INVALID NODE TYPE) in multiple test cases, and what is its meaning?
Mainly the body of ginkgo.By
blocks.
I see, sgtm /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mimowo, trasc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
LGTM label has been added. Git tree hash: ebf9b8fc60ff358c4e771d24447d58f201afc537
|
What type of PR is this?
/kind feature
What this PR does / why we need it:
Adds a way to analyse the time consumption of the ginkgo based tests (integration and e2e).
The test are now exporting the
json
report which is then processed by a small tool which lists the test specs in reverse order of the time taken by them to complete, for example integration-top.yamlWhich issue(s) this PR fixes:
Relates to #2993
Special notes for your reviewer:
Does this PR introduce a user-facing change?