Provide Kubeflow XGBoostJob support for MultiKueue #2746
Conversation
|
Skipping CI for Draft Pull Request. |
k8s-ci-robot
added
do-not-merge/work-in-progress
k8s-ci-robot
added
the
size/XL
✅ Deploy Preview for kubernetes-sigs-kueue canceled.
|
|
/ok-to-test |
k8s-ci-robot
added
the
ok-to-test
mszadkow
force-pushed
the
feature/support-kubeflow-xgboost-in-mk
branch
from
8cb3e5e
to
218f61f
Compare
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
mszadkow
force-pushed
the
feature/support-kubeflow-xgboost-in-mk
branch
from
218f61f
to
53e6762
Compare
pkg/controller/jobs/kubeflow/jobs/xgboostjob/xgboostjob_controller.go
Outdated
Show resolved
Hide resolved
|
|
||
| type multikueueAdapter struct{} | ||
|
|
||
| var _ jobframework.MultiKueueAdapter = (*multikueueAdapter)(nil) |
There was a problem hiding this comment.
The adapter code is almost identical between the integrations. I would like to put effort at some point to commonize it, at least for Kubeflow. @mszadkow could you attempt commonizing them in this PR, or in a follow up?
There was a problem hiding this comment.
Sure I will make the attempt, I would prefer in follow up
There was a problem hiding this comment.
Sg, I will prefer to commonize the adapters for the 2 integrations we currently have before adding new ones.
There was a problem hiding this comment.
Ok, I will do that thing first
There was a problem hiding this comment.
to be clear it is ok in a follow up to this pr.
There was a problem hiding this comment.
+1
Commonizing the adapters would be better.
mszadkow
force-pushed
the
feature/support-kubeflow-xgboost-in-mk
branch
from
72c6a3b
to
0f62592
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: b01cfec9461b9a48692f692df26998c5fa4f80ad
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mimowo, mszadkow The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
What type of PR is this?
/kind feature
What this PR does / why we need it:
The PR introduces a new MultiKueue adapter to handle XGBoostJob (Kubeflow).
We want to extend MultiKueue capabilities to satisfy the needs of early adopters.
Which issue(s) this PR fixes:
Relates #2552
Special notes for your reviewer:
Does this PR introduce a user-facing change?