✨ return set of issues when EKS Node Group is in degraded state #4811

stefanSpectro · 2024-02-22T23:09:49Z

What type of PR is this?
/kind feature

What this PR does / why we need it:

We need this PR because when node groups go in to a degraded state no relevant information is returned to the user. This PR implements code that returns a set of health issues reported for the given node group so a user can have an understanding of what went wrong.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Checklist:

Release note:

Return detailed error message to user when EKS NodeGroup goes in to a Degraded state

linux-foundation-easycla · 2024-02-22T23:09:53Z

The committers listed above are authorized under a signed CLA.

✅ login: stefanSpectro (8aa13f7)

k8s-ci-robot · 2024-02-22T23:09:57Z

Welcome @stefanSpectro!

It looks like this is your first PR to kubernetes-sigs/cluster-api-provider-aws 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api-provider-aws has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2024-02-22T23:09:58Z

Hi @stefanSpectro. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Ankitasw · 2024-03-06T06:20:00Z

/test pull-cluster-api-provider-aws-e2e-eks

Ankitasw · 2024-03-07T06:55:30Z

pkg/cloud/services/eks/nodegroup.go

+			errMsgStr = fmt.Sprintf("%s %s", errMsgStr, errMsg)
+		}
+		reason := capierrors.InvalidConfigurationMachineError
+		// TODO: implement checks for other MachineStatusErrors and set reason accordingly


Are you planning to add this TODO as part of this PR?

Hi @Ankitasw I was going to leave this TODO as this PR is implementing returning of the error set.

Ankitasw · 2024-03-27T05:56:17Z

@stefanSpectro would you be able to continue this PR?

k8s-triage-robot · 2024-06-25T06:06:35Z

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle stale
Close this PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot · 2024-07-25T06:23:32Z

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle rotten
Close this PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot · 2024-08-24T07:14:32Z

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Reopen this PR with /reopen
Mark this PR as fresh with /remove-lifecycle rotten
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

k8s-ci-robot · 2024-08-24T07:14:37Z

@k8s-triage-robot: Closed this PR.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied

After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied

After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Reopen this PR with /reopen

Mark this PR as fresh with /remove-lifecycle rotten

Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

stefanSpectro · 2024-09-03T14:44:41Z

/reopen

k8s-ci-robot · 2024-09-03T14:44:46Z

@stefanSpectro: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot · 2024-09-03T14:44:52Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign sbueringer for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

stefanSpectro · 2024-09-25T16:43:53Z

@Ankitasw any chance you could please take a look when you have time? Thanks

k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Feb 22, 2024

k8s-ci-robot requested review from Ankitasw and dlipovetsky February 22, 2024 23:09

k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. needs-priority labels Feb 22, 2024

k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 22, 2024

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Feb 22, 2024

stefanSpectro changed the title ~~return set of issues when ng is in degraded state~~ ✨ return set of issues when ng is in degraded state Feb 22, 2024

stefanSpectro mentioned this pull request Feb 22, 2024

log set of issues when node group in degraded state spectrocloud/cluster-api-provider-aws#879

Open

4 tasks

Ankitasw added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 7, 2024

Ankitasw reviewed Mar 7, 2024

View reviewed changes

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 25, 2024

k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jul 25, 2024

k8s-ci-robot closed this Aug 24, 2024

k8s-ci-robot reopened this Sep 3, 2024

stefanSpectro force-pushed the return-set-of-issues-when-ng-in-degraded-state branch from 2dda998 to 8307d07 Compare September 3, 2024 15:09

k8s-ci-robot added the do-not-merge/contains-merge-commits label Sep 3, 2024

stefanSpectro force-pushed the return-set-of-issues-when-ng-in-degraded-state branch from ebbcfa7 to a249c0f Compare September 3, 2024 19:22

stefanSpectro force-pushed the return-set-of-issues-when-ng-in-degraded-state branch from 7d706e0 to e3ca115 Compare September 5, 2024 15:12

stefanSpectro changed the title ~~✨ return set of issues when ng is in degraded state~~ ✨ return set of issues when EKS Node Group is in degraded state Sep 5, 2024

return set of issues when ng is in degraded state

8aa13f7

stefanSpectro force-pushed the return-set-of-issues-when-ng-in-degraded-state branch from e3ca115 to 8aa13f7 Compare September 10, 2024 15:02

k8s-ci-robot removed the do-not-merge/contains-merge-commits label Sep 10, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

✨ return set of issues when EKS Node Group is in degraded state #4811

✨ return set of issues when EKS Node Group is in degraded state #4811

stefanSpectro commented Feb 22, 2024 •

edited

Loading

linux-foundation-easycla bot commented Feb 22, 2024 •

edited

Loading

k8s-ci-robot commented Feb 22, 2024

k8s-ci-robot commented Feb 22, 2024

Ankitasw commented Mar 6, 2024

Ankitasw Mar 7, 2024

stefanSpectro Sep 3, 2024

Ankitasw commented Mar 27, 2024

k8s-triage-robot commented Jun 25, 2024

k8s-triage-robot commented Jul 25, 2024

k8s-triage-robot commented Aug 24, 2024

k8s-ci-robot commented Aug 24, 2024

stefanSpectro commented Sep 3, 2024

k8s-ci-robot commented Sep 3, 2024

k8s-ci-robot commented Sep 3, 2024

stefanSpectro commented Sep 25, 2024

✨ return set of issues when EKS Node Group is in degraded state #4811

Are you sure you want to change the base?

✨ return set of issues when EKS Node Group is in degraded state #4811

Conversation

stefanSpectro commented Feb 22, 2024 • edited Loading

linux-foundation-easycla bot commented Feb 22, 2024 • edited Loading

k8s-ci-robot commented Feb 22, 2024

k8s-ci-robot commented Feb 22, 2024

Ankitasw commented Mar 6, 2024

Ankitasw Mar 7, 2024

Choose a reason for hiding this comment

stefanSpectro Sep 3, 2024

Choose a reason for hiding this comment

Ankitasw commented Mar 27, 2024

k8s-triage-robot commented Jun 25, 2024

k8s-triage-robot commented Jul 25, 2024

k8s-triage-robot commented Aug 24, 2024

k8s-ci-robot commented Aug 24, 2024

stefanSpectro commented Sep 3, 2024

k8s-ci-robot commented Sep 3, 2024

k8s-ci-robot commented Sep 3, 2024

stefanSpectro commented Sep 25, 2024

stefanSpectro commented Feb 22, 2024 •

edited

Loading

linux-foundation-easycla bot commented Feb 22, 2024 •

edited

Loading