fix: revert failed pods marked as NotReady #821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
revert failed pod marked as NotReady
|
This PR has been automatically marked as stale because it has not The next time this stale check runs, the stale label will be Thank you for your contributions! |
|
This is still a thing |
skl
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts to what I think is the correct behavior.
GracefulNodeShutdownfeatures (enabled by default with 1.21) terminates pods on nodes and set theyphasetoFailed. However, these are evicted and should not be taken as failures. See kubernetes/kubernetes#113278.See details in the history:
Initial issue #215
Added #1
Reverted #70
Added #221
Reverted #296
Added #784
I guess this query could be enhanced to support these previous use cases, however, changing it like it was done previously alerts on default Kubernetes behavior.