KEP-2170: Generate clientset, openapi spec for the V2 APIs #2273
Conversation
Generate clientset, informers, listers and open api spec for v2alpha1 APIs. Signed-off-by: Varsha Prasad Narsing <[email protected]>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Pull Request Test Coverage Report for Build 11078444638Details
💛 - Coveralls |
| @@ -72,10 +72,10 @@ chmod +x ${CODEGEN_PKG}/generate-internal-groups.sh | |||
| # k8s.io/kubernetes. The output-base is needed for the generators to output into the vendor dir | |||
| # instead of the $GOPATH directly. For normal projects this can be dropped. | |||
| cd ${SCRIPT_ROOT} | |||
| echo "Generating client,lister,informer for kubeflow.org/v1" | |||
| echo "Generating client,lister,informer for kubeflow.org/v1 and kubeflow.org/v2alpha1" | |||
| ${CODEGEN_PKG}/generate-groups.sh "client,lister,informer" \ | |||
There was a problem hiding this comment.
This script needs to be refactored to use kube_codegen.sh . The k8s deps need to be bumped to use the latest kube_codegen args. Will create a separate issue to track the same.
andreyvelich
changed the title
There was a problem hiding this comment.
Thank you for adding this @varshaprasad96!
I will review it this week.
/assign @kubeflow/wg-training-leads @akshaychitneni @saileshd1402
What this PR does / why we need it:
Generate clientset, informers, listers and open api spec for v2alpha1 APIs.
Which issue(s) this PR fixes (optional, in
Fixes #<issue number>, #<issue number>, ...format, will close the issue(s) when PR gets merged):Fixes #2224
Checklist: