Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tf job examples to tf v2 #2270

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

YosiElias
Copy link
Contributor

@YosiElias YosiElias commented Sep 25, 2024

What this PR does / why we need it:
Update TFjob examples to TF v2

Which issue(s) this PR fixes (optional, in Fixes #<issue number>, #<issue number>, ... format, will close the issue(s) when PR gets merged):
Fixes #2015

Checklist:

  • Docs included if any changes are user facing

Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign tenzen-y for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coveralls
Copy link

Pull Request Test Coverage Report for Build 11046684566

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 11001381410: 0.0%
Covered Lines: 66
Relevant Lines: 66

💛 - Coveralls

@YosiElias
Copy link
Contributor Author

Hi @alongzhi, I saw you added ppc64le images before.
In order to support ppc64le I need base image of TF-v2 to replace this image - ibmcom/tensorflow-ppc64le:1.13.1 that used in: examples/tensorflow/dist-mnist/Dockerfile.ppc64le and examples/tensorflow/mnist_with_summaries/Dockerfile.ppc64le.

Can you pls support this image? otherwise just let me know and I'll remove this Dockerfile.ppc64le since the source code support only TF-v2 now..

@JosepSampe @ckadner Do you know who can support this image from IBM?

@andreyvelich - FYI

@andreyvelich
Copy link
Member

@alongzhi Are you planning to continue support powerPC images in Training Operator ?
Otherwise, we will remove them.
cc @kubeflow/wg-training-leads

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adapt TFJob examples to TensorFlow v2
3 participants