Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDK] Minor fix in wait_for_job_conditions with job_kind python training API #2265

Merged

Conversation

saileshd1402
Copy link
Contributor

@saileshd1402 saileshd1402 commented Sep 21, 2024

What this PR does / why we need it:
This PR fixes a minor bug in the wait_for_job_conditions function of the python training SDK

Which issue(s) this PR fixes (optional, in Fixes #<issue number>, #<issue number>, ... format, will close the issue(s) when PR gets merged):
Fixes #

Checklist:

  • Docs included if any changes are user facing

Bug

  • Encountered this bug when testing the create-tfjob.ipynb notebook example
  • When job_kind (which is not PyTorch job kind) is passed in wait_for_job_conditions the SDK throws a ValueError.
    Example code:
    TrainingClient(namespace=namespace).wait_for_job_conditions(name, job_kind=constants.TFJOB_KIND)

Error:

ValueError: Job must be one of these types: KubeflowOrgV1PyTorchJob ('KubeflowOrgV1TFJob', 'KubeflowOrgV1PyTorchJob', 'KubeflowOrgV1XGBoostJob', 'KubeflowOrgV1MPIJob', 'KubeflowOrgV1PaddleJob', 'KubeflowOrgV1JAXJob')

Fix

@saileshd1402 saileshd1402 changed the title [BUG] Minor fix in wait_for_job_conditions with job_kind python training API [SDK] Minor fix in wait_for_job_conditions with job_kind python training API Sep 21, 2024
Signed-off-by: sailesh duddupudi <[email protected]>
@coveralls
Copy link

Pull Request Test Coverage Report for Build 10974037171

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 10963743211: 0.0%
Covered Lines: 66
Relevant Lines: 66

💛 - Coveralls

Copy link
Member

@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great find, thanks for the fix @saileshd1402!
/lgtm
/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit bd82422 into kubeflow:master Sep 23, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants