-
Notifications
You must be signed in to change notification settings - Fork 689
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to controller-runtime logger in mpi job controller #2177
base: master
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Pull Request Test Coverage Report for Build 10006593907Details
💛 - Coveralls |
89ae18a
to
00b6c51
Compare
Signed-off-by: champon1020 <[email protected]>
00b6c51
to
bbc9872
Compare
@@ -74,7 +72,7 @@ func NewReconciler(mgr manager.Manager, gangSchedulingSetupFunc common.GangSched | |||
Scheme: mgr.GetScheme(), | |||
recorder: mgr.GetEventRecorderFor(controllerName), | |||
apiReader: mgr.GetAPIReader(), | |||
Log: log.Log, | |||
Log: log.Log.WithName(controllerName), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note: attach controllerName as the logger name
}() | ||
|
||
mpiJob = mpiJob.DeepCopy() | ||
mpiJob.Status = *jobStatus.DeepCopy() | ||
|
||
result := jc.Status().Update(context.Background(), mpiJob) | ||
|
||
if result != nil { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note: I think this if statement may be no longer needed
What this PR does / why we need it:
As mentioned at #2048, we should migrate to Controller Runtime Logger while there are some types of logger currently. First, I modified it only in the MPI Job Controller since I want to determine a course of action. (I'm going to implement the remaining modifications in the next PR)
Which issue(s) this PR fixes (optional, in
Fixes #<issue number>, #<issue number>, ...
format, will close the issue(s) when PR gets merged):Fixes #2048
Checklist: