Skip to content

Commit

Permalink
Fix uses path
Browse files Browse the repository at this point in the history
Signed-off-by: sailesh duddupudi <[email protected]>
  • Loading branch information
saileshd1402 committed Sep 29, 2024
1 parent 222bf0e commit 34be848
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 8 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/test-example-notebooks.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:
python-version: ["3.9", "3.10", "3.11"]
steps:
- name: Test Notebook
uses: .github/workflows/template-notebook-test
uses: ./.github/workflows/template-notebook-test
with:
kubernetes-version: ${{ matrix.kubernetes-version }}
python-version: ${{ matrix.python-version }}
Expand Down
19 changes: 12 additions & 7 deletions examples/pytorch/image-classification/create-pytorchjob.ipynb
Original file line number Diff line number Diff line change
Expand Up @@ -129,10 +129,14 @@
" metadata=V1ObjectMeta(\n",
" name=name,\n",
" namespace=namespace,\n",
" annotations={\"sidecar.istio.io/inject\": \"false\"},\n",
" annotations={\n",
" \"sidecar.istio.io/inject\": \"false\"\n",
" }\n",
" ),\n",
" spec=V1PodSpec(containers=[container]),\n",
" ),\n",
" spec=V1PodSpec(\n",
" containers=[container]\n",
" )\n",
" )\n",
")\n",
"\n",
"pytorchjob = KubeflowOrgV1PyTorchJob(\n",
Expand All @@ -141,7 +145,10 @@
" metadata=V1ObjectMeta(name=name, namespace=namespace),\n",
" spec=KubeflowOrgV1PyTorchJobSpec(\n",
" run_policy=KubeflowOrgV1RunPolicy(clean_pod_policy=\"None\"),\n",
" pytorch_replica_specs={\"Master\": replica_spec, \"Worker\": replica_spec},\n",
" pytorch_replica_specs={\n",
" \"Master\": replica_spec,\n",
" \"Worker\": replica_spec\n",
" },\n",
" ),\n",
")"
]
Expand Down Expand Up @@ -308,9 +315,7 @@
"source": [
"pytorchjob = training_client.wait_for_job_conditions(name=name)\n",
"\n",
"print(\n",
" f\"Succeeded number of replicas: {pytorchjob.status.replica_statuses['Master'].succeeded}\"\n",
")"
"print(f\"Succeeded number of replicas: {pytorchjob.status.replica_statuses['Master'].succeeded}\")"
]
},
{
Expand Down

0 comments on commit 34be848

Please sign in to comment.