Add Redis CMD for data insert #709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shaad7 <[email protected]>
Signed-off-by: Shaad7 <[email protected]>
Signed-off-by: Shaad7 <[email protected]>
Signed-off-by: Shaad7 <[email protected]>
Signed-off-by: Shaad7 <[email protected]>
Signed-off-by: Shaad7 <[email protected]>
Signed-off-by: Shaad7 <[email protected]>
Signed-off-by: Shaad7 <[email protected]>
Signed-off-by: Shaad7 <[email protected]>
Signed-off-by: Shaad7 <[email protected]>
Signed-off-by: Shaad7 <[email protected]>
Signed-off-by: Shaad7 <[email protected]>
Signed-off-by: Shaad7 <[email protected]>
Signed-off-by: Shaad7 <[email protected]>
ArnobKumarSaha
requested changes
Aug 17, 2023
pkg/data/redis.go
Outdated
| if err != nil { | ||
| return err | ||
| } | ||
| fmt.Printf("\nExpected keys: %d .Redis database %s/%s contains: %d keys\n", rows, opts.db.Namespace, opts.db.Name, totalKeys) |
There was a problem hiding this comment.
if rows doesn't matched totalKey, we can show that. But if they matched, we should show some Success type message to the user.
There was a problem hiding this comment.
Should it be exact match ? Because in Redis, we insert some keys for health check. That also comes when we take the total count. What about greater or equal ?
AbdullahAlShaad
force-pushed
the
data
branch
2 times, most recently
from
9ac5100
to
fa09948
Compare
Signed-off-by: Shaad7 <[email protected]>
Signed-off-by: Shaad7 <[email protected]>
pritamdas99
requested changes
Aug 17, 2023
| func DropRedisDataCMD(f cmdutil.Factory) *cobra.Command { | ||
| var dbName string | ||
|
|
||
| rdVerifyCmd := &cobra.Command{ |
ArnobKumarSaha
approved these changes
Aug 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.