Add boardgames, lecture proposal form, dark mode #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…inside the container
Arsenicro
suggested changes
Oct 19, 2024
| queryKey: [zosiaApiRoutes.addLectureDurations, lectureType], | ||
| queryFn: async ({ queryKey }) => { | ||
| const lecture = queryKey[1]; | ||
| if (lecture === "") { |
There was a problem hiding this comment.
We should validate outside of the query function; the query function is only for calling an API.
| const lecture = queryKey[1]; | ||
| if (lecture === "") { | ||
| return Promise.resolve<LectureDurations>({ | ||
| durations: ["Please choose lecture type first!"], |
There was a problem hiding this comment.
That is especially weird because, in fact, we have an error, and outside of it, we think it is a valid response
|
|
||
| const onCheckboxChange = (boardGameId: number, checked: boolean) => { | ||
| if (checked) { | ||
| setVotes([...votes, boardGameId]); |
There was a problem hiding this comment.
Theoretically, it would be better to use functional setState in both cases, it may cause less bugs
Suggested change
| setVotes([...votes, boardGameId]); | |
| setVotes(oldVotes => ([...oldVotes, boardGameId])); |
| } | ||
| }; | ||
|
|
||
| const isVoteLimitReached = votes.length >= 3; |
There was a problem hiding this comment.
Is this also validated on backend?
| * This approach is inspired by this blogpost: | ||
| * https://hangindev.com/blog/avoid-flash-of-default-theme-an-implementation-of-dark-mode-in-react-app | ||
| */ | ||
| export const themeInitScript = ` |
There was a problem hiding this comment.
I'm not a fan of this approach. Isn't file app/server/templates/base.html the one to which we will inject this code? Can't we add this code there?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains: